Code components and overrides use incorrect icon in review changes panel

Created on 15 March 2025, 21 days ago

Overview

In the โ€œReview changesโ€ panel, Code Components and Overrides are shown with the generic component icon. This inconsistency makes it harder to interpret the changes in the review changes panel.

Proposed resolution

Use the correct icons in the review changes panel.

User interface changes

๐Ÿ› Bug report
Status

Active

Version

0.0

Component

Page builder

Created by

๐Ÿ‡ซ๐Ÿ‡ฎFinland lauriii Finland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @lauriii
  • First commit to issue fork.
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ

    Gave this a quick try. Not sure how to create overrides though.

  • Pipeline finished with Canceled
    21 days ago
    Total: 755s
    #449075
  • Pipeline finished with Failed
    21 days ago
    Total: 920s
    #449093
  • ๐Ÿ‡ซ๐Ÿ‡ฎFinland lauriii Finland

    @penyaskito You need to enable xb_dev_js_blocks module for overrides to show up in the UI.

  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ

    Thanks! I validated the fix works for overrides too.

  • ๐Ÿ‡ณ๐Ÿ‡ฑNetherlands balintbrews Amsterdam, NL

    Looks great!

    Two minor things:

    1. I think we can get rid of all instances of IconType.COMPONENT1, as well as the styling for that type. Unless, see my question below.
    2. Can you please also update the stories for the PublishReview component? We don't have a lot of stories in our Storybook, this component does have them. ๐Ÿ™‚

    Question to @lauriii, is it okay to use the same code icon for the exposed code components? They get a different icon the sidebar in that case, that's why I'm asking.

    Also, do we want to update the icon for Global CSS as well while we're here? The API endpoint returns icon: 'cms' for it, so we may want to adjust this on the backend, but it's also easy to look at the entity type in the frontend component.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States reneelund
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ
  • Pipeline finished with Failed
    11 days ago
    Total: 1101s
    #457422
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ

    NR.
    #7: Got rid of every Component1Icon. There are a couple of cases that could be discussed:
    1. New component menu: Does nothing, Laurii confirmed we can delete that.
    2. Not sure about my PageInfo checks, definitely appreciate feedback there @balintbrews

  • Pipeline finished with Failed
    10 days ago
    Total: 865s
    #458244
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ

    Test failure is unrelated.

  • ๐Ÿ‡ณ๐Ÿ‡ฑNetherlands balintbrews Amsterdam, NL
  • Pipeline finished with Failed
    9 days ago
    Total: 959s
    #459127
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ

    Fixed feedback.

  • Pipeline finished with Failed
    3 days ago
    Total: 1834s
    #463600
  • ๐Ÿ‡ช๐Ÿ‡ธSpain penyaskito Seville ๐Ÿ’ƒ, Spain ๐Ÿ‡ช๐Ÿ‡ธ, UTC+2 ๐Ÿ‡ช๐Ÿ‡บ
Production build 0.71.5 2024