- Issue created by @lauriii
- First commit to issue fork.
- Merge request !788Issue #3513145: Code components and overrides use incorrect icon in review changes panel โ (Open) created by penyaskito
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Gave this a quick try. Not sure how to create overrides though.
- ๐ซ๐ฎFinland lauriii Finland
@penyaskito You need to enable
xb_dev_js_blocks
module for overrides to show up in the UI. - ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Thanks! I validated the fix works for overrides too.
- ๐ณ๐ฑNetherlands balintbrews Amsterdam, NL
Looks great!
Two minor things:
- I think we can get rid of all instances of
IconType.COMPONENT1
, as well as the styling for that type. Unless, see my question below. - Can you please also update the stories for the
PublishReview
component? We don't have a lot of stories in our Storybook, this component does have them. ๐
Question to @lauriii, is it okay to use the same code icon for the exposed code components? They get a different icon the sidebar in that case, that's why I'm asking.
Also, do we want to update the icon for Global CSS as well while we're here? The API endpoint returns
icon: 'cms'
for it, so we may want to adjust this on the backend, but it's also easy to look at the entity type in the frontend component. - I think we can get rid of all instances of
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
NR.
#7: Got rid of every Component1Icon. There are a couple of cases that could be discussed:
1. New component menu: Does nothing, Laurii confirmed we can delete that.
2. Not sure about my PageInfo checks, definitely appreciate feedback there @balintbrews - ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Test failure is unrelated.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Fixed feedback.