Contrib.social

Workflow labels not getting used

Open on Drupal.org →
Created on 14 March 2025, 23 days ago

Problem/Motivation

In testing the latest dev-branch of Workflow (as of today), I noticed that some of our tests are now failing because the label on the transition forms is no longer correct. It looks like the custom-configured transition labels are not being used when building this form.

Steps to reproduce

Configure a workflow state transition to have a custom label (/admin/config/workflow/workflow/external_publication/transition_labels)
Go to a node form that uses this workflow, and observe the label uses the name of the state, instead of your custom label.

Proposed resolution

Again, it seems like this is related to some of the recent work, and possibly most closely related to the "Select a label" thing as it appears to be connected to how we render the transition form. I haven't had a chance to dig into it any further than that, this is currently where I'm stuck :)

Remaining tasks

Understand where these option labels are being built in the new codebase
Correct that code to properly use the custom labels ;)

User interface changes

Custom labels will appear correctly :)

API changes

TBD

Data model changes

TBD

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇨🇦Canada spiderman Halifax, NS

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @spiderman
  • Comment 22 days ago →
    🇳🇱Netherlands johnv

    I cannot reproduce this. 'Transition labels' are correctly displayed in the selectlist/reios/buttons.

  • Comment 20 days ago →
    🇳🇱Netherlands johnv
  • Comment 20 days ago →
    🇨🇦Canada spiderman Halifax, NS

    @johnv: I will take another look at this today or tomorrow. It's possible I only saw this in the context of my client project, in which case there may be other factors at play. I'll see if I can reproduce in a clean environment and report back :)

  • Comment 18 days ago →
    🇨🇦Canada spiderman Halifax, NS

    @johnv: I've managed to do some further testing on this today, and it looks like whatever I saw earlier has gone away. The custom labels are working properly in my test environment, but I also cannot reproduce the failure I was seeing previously. As such, I'm closing this, with apologies for the noise :)

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024