Contrib.social

Adapt to upcoming 1.9 release of Workflow

Open on Drupal.org →
Created on 14 March 2025, 4 months ago

I've been testing this module in the context of the latest dev-branch of Workflow module, which the maintainer is preparing for a 1.9 release. There are a number of known issues in 1.8 that they are seeking to fix, and so we want to prepare this module to make that jump as well.

Proposed resolution

Put this module through it's paces against the latest dev-branch of Workflow, and maintain a patch (or perhaps new release branch, if the Workflow release is not imminent) to adapt our codebase to the modified API for Workflow 1.9.

Remaining tasks

I've already put together a basic patch that adapts to the latest codebase as of today (March 14, 2025). I'll post this here for now, and continue to track the updates in Workflow itself, posting updates here as needed.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇨🇦Canada spiderman Halifax, NS

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @spiderman
  • Comment 4 months ago →
    🇨🇦Canada spiderman Halifax, NS
  • Comment 3 months ago →
    🇨🇦Canada spiderman Halifax, NS

    I noticed some bits were missing from the patch to make this work against the latest Workflow code. Attached is a new patch with interdiff showing added HookHandler bits etc.

  • Status changed to Needs review 9 days ago
  • Comment 9 days ago →
    🇳🇱Netherlands johnv

    Attached patch is updated for ECA v2.1.8 and Workflow v2.1.

    It also contains resolved incompatibilities between ECA v1 and ECA v2.
    I did not truly test a 'model'.

    I took the liberty to:
    - not make dependent on D11, but D11.2, since that is my dev environment
    - not make dependent on Workflow version 1.8 (which is obsolete), 1.9 (which does not exist), 2.0 (which has had a short lifetime), but 2.1 (of which 2.1.2 is current version)

    It contains also 2 @todo's, where my IDE tells me there is a problem, I cannot fix myself.

  • Comment 9 days ago →
    🇳🇱Netherlands johnv
  • Comment 6 days ago →
    🇳🇱Netherlands johnv

    Please find attached a new version, after testing an Event + Action.
    I did not find a way to test a Condition, though.

  • Comment 5 days ago →
    🇳🇱Netherlands johnv

    Please find attached a new version, after also having tested the 'WorkflowFieldValue' condition.

    Some remarks:
    - The 'WorkflowHasField' condition is not tested yet.
    - The buildConfigurationForm from the Event is removed. IMO events have no configuration
    - The buildConfigurationForm from the Condition - I do not understand how the UI gets its values. The code has no default values, but the UI has.
    - There are some @todo's.

    Sorry for not using MR.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024