Adapt to upcoming 1.9 release of Workflow

I noticed some bits were missing from the patch to make this work against the latest Workflow code. Attached is a new patch with interdiff showing added HookHandler bits etc.

Attached patch is updated for ECA v2.1.8 and Workflow v2.1.

It also contains resolved incompatibilities between ECA v1 and ECA v2.
I did not truly test a 'model'.

I took the liberty to:
- not make dependent on D11, but D11.2, since that is my dev environment
- not make dependent on Workflow version 1.8 (which is obsolete), 1.9 (which does not exist), 2.0 (which has had a short lifetime), but 2.1 (of which 2.1.2 is current version)

It contains also 2 @todo's, where my IDE tells me there is a problem, I cannot fix myself.

Please find attached a new version, after testing an Event + Action.
I did not find a way to test a Condition, though.

Please find attached a new version, after also having tested the 'WorkflowFieldValue' condition.

Some remarks:
- The 'WorkflowHasField' condition is not tested yet.
- The buildConfigurationForm from the Event is removed. IMO events have no configuration
- The buildConfigurationForm from the Condition - I do not understand how the UI gets its values. The code has no default values, but the UI has.
- There are some @todo's.

Sorry for not using MR.

+    $configuration = $form_state->getValues();
+    // The $values are not set to the latest values, so read from $input.
+    $configuration = $form_state->getUserInput()['configuration'];

$configuration is assigned twice.

Also, that last line should be:

$configuration = $form_state->getUserInput()['condition'];

This is using ECA Classic Modeller because BPMN.iO doesn't seem support the "PMT: compare workflow field value" condition.

I'm using this to send an email on state change, however the email is sent twice. I'm not sure why at this stage.

Another problem is that the transition event can be triggered multiple times.

For example, on a workflow transition with the condition "compare workflow field value" set to "Published" , the action "Publish content item" is fired.

Publishing the content item then triggers another transistion event. Comparing the previous and and current states in HookHandler shows they are still different, even though they probably shoudn't be.

MR created but it probably still needs some work.

There are a lot of things in the repository which shouldn't be, such as .local-dev and links to other repositories.

OK BPMN.iO is working fine.

However, the transition event is firing more than once for each transition.

I can't get this to work properly and I've run out of time at the moment.

@johnv:

- The buildConfigurationForm from the Condition - I do not understand how the UI gets its values. The code has no default values, but the UI has

When using the WorkflowFieldValue condition after detecting a transition event, the selected items (field name, field value, expected value etc.) can't be found and all end up empty, therefore always returning true no matter what is set in the config form.

The config form has the correct values.

@johnv,

- The buildConfigurationForm from the Event is removed. IMO events have no configuration

The event for core's Workflows transition includes optional configuration for the from and to state.

sorry, if I ask a silly question, after the resolving of this issue, can we use this module with D11(.2.x), Workflow 2.1(.x) and ECA 3(.x) too?