Remove optimization in LocationIndices

Created on 13 March 2025, about 2 months ago

Problem/Motivation

LocationIndices::set() tries to reuse ranges of location indices. That only works if the traces are indexed which are in root-to-leaf order. Since 🐛 Stack trace is upside down in pyroscope Active this is not the case anymore. The optimization should be removed.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇨🇭Switzerland znerol

Live updates comments and jobs are added and updated live.

Merge Requests

!4Remove optimization in LocationIndices
Merged
🇨🇭Switzerland znerol
updated about 2 months ago

Comments & Activities

Issue created by @znerol
Merge request !4Issue #3512850: Remove premature optimization in LocationIndices → (Merged) created by znerol
Pipeline finished with Skipped
about 2 months ago
#447861
Comment about 2 months ago →
System Message

znerol → committed ad3d814b on 1.x
Issue #3512850: Remove optimization in LocationIndices
Comment about 2 months ago →
🇨🇭Switzerland znerol
Comment about 1 month ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024