Contrib.social

Store Selection

Open on Drupal.org →
Created on 12 March 2025, 24 days ago

Problem/Motivation

There is an issue with store selection in certain circumstances.

I documented a similar issue here: https://www.drupal.org/project/commerce_stock/issues/3150560#comment-160... 🐛 Multistore and context Fixed

This issue is related to https://www.drupal.org/project/direct_checkout_by_url/issues/3019628 📌 Use getStore trait if it gets commited Needs review but the problem is the same with and without this PR as the logic is basically the same.

Not sure where we should add the correct functionality, my hunch is this maybe an issue with the SelectStoreTrait but I guess core is expecting us to ensure the correct store is chosen up front.

Steps to reproduce

Currently I have Store A, B, C. Store A is my default store so this is almost always the one used when adding a product to the cart using this module.

Product 1 assigned to Store A - works fine
Product 2 assigned to Store B - works fine (as the logic in the just uses the store if there is only one selected, regardless of actual context)
Product 3 assigned to Store B and C - exception thrown.

Proposed resolution

I believe there are 3 options

1. Try to get a patch into commerce core with better logic (unclear what that is)
2. Create our own logic as per commerce stock (fall back to selecting the first assigned store if one exists)
3. Add a way to select the store upfront

None are ideal personally I think a combination of 2 and 3 would be good?

Remaining tasks

  • Create a patch for passing in store via query string
  • Update select store to work, this would conflict with 3019628 as I doubt we would use the SelectStoreTrait
🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom chrisscrumping

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chrisscrumping
  • Merge request !103512437 Add store paramater improve store selection logic → (Open) created by chrisscrumping
  • Pipeline finished with Failed
    23 days ago
    Total: 142s
    #447621
  • Comment 23 days ago →
    🇬🇧United Kingdom chrisscrumping

    I think the CI is failing because its using Drupal 11 and we need to update to Commerce 3 to use that?

  • Comment 23 days ago →
    🇬🇧United Kingdom chrisscrumping

    Tried doing this locally but getting lots of errors and no time to look into it right now unfortunately.

    1) Drupal\Tests\direct_checkout_by_url\Functional\RedirectTest::testSimpleUrl
Drupal\Core\Installer\Exception\InstallerException: Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/docs/installing-drupal">installation handbook</a>, or contact your hosting provider.

/var/www/html/web/core/includes/install.core.inc:989
/var/www/html/web/core/includes/install.core.inc:619
/var/www/html/web/core/includes/install.core.inc:572
/var/www/html/web/core/includes/install.core.inc:121
/var/www/html/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:315
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:550
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/var/www/html/web/modules/contrib/commerce/tests/src/Functional/CommerceBrowserTestBase.php:64
/var/www/html/tests/src/Functional/RedirectTest.php:85

    Line 85: parent::setUp();

  • Comment 23 days ago →
    🇬🇧United Kingdom chrisscrumping
  • Comment 23 days ago →
    🇬🇧United Kingdom chrisscrumping

    We also need to ensure the product variation order type is used when creating the cart so that the correct checkout flow is used on checkout.

  • Pipeline finished with Failed
    23 days ago
    Total: 147s
    #447674
  • Comment 23 days ago →
    🇬🇧United Kingdom chrisscrumping
  • Pipeline finished with Failed
    22 days ago
    Total: 135s
    #448354
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024