- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
I think we only need to add dependencies in the d10-plus and d7-composer branches, as those have a composer.json file.
d9-basic and d7-basic do not have a composer.jon. I know that we can add dependencies via the .info(.yml) files but that is probably not needed here. Will two out of the four suffice?
- 🇬🇧United Kingdom jonathan1055
Those both work OK. In d10-plus 'webform' needed to be added to a custom
.cspell-project-words.txt
which is good, as we did not have any projects with that file, so this change increases test coverage of the spelling job.In the d7-composer job we get a nice output confirming where the dependency modules have been located. It could be good to add a similar one- or -two-liner in the d10 template. But that's a separate issue. Both of these MRs are ready for review.
- 🇪🇸Spain fjgarlin
MR19 and MR20 look good.
For modern Drupal, we have the composer output, but yeah, maybe a 1-2 liner with just the contrib modules can be nice (separate issue).
-
jonathan1055 →
committed ab075c78 on d10-plus
Issue #3512218 by jonathan1055, fjgarlin: Require some 3rd-party modules...
-
jonathan1055 →
committed ab075c78 on d10-plus
-
jonathan1055 →
committed dc2137f1 on d7-composer
Issue #3512218 by jonathan1055, fjgarlin: Require some 3rd-party modules...
-
jonathan1055 →
committed dc2137f1 on d7-composer
- 🇬🇧United Kingdom jonathan1055
I had an idea (after this was merged) that the new
.cspell-project-words.txt
might clash with the processing we do in < code>BEFORE_SCRIPT_ACTIONS to force and then fix a spelling error. And indeed it does cause the job to fail when run with action 'cspell-project-words'. It should be a simple fix, instead of creating the .txt file with>
it should append with>>
in case the file already exists.
- 🇬🇧United Kingdom jonathan1055
Existing, with spelling failure has
This is .cspell-project-words.txt madeupword
MR21 cspell log passes, because it has
This is .cspell-project-words.txt webform madeupword
-
jonathan1055 →
committed 4f1fa7e4 on d10-plus
Issue #3512218 by jonathan1055, fjgarlin: Require some 3rd-party modules...
-
jonathan1055 →
committed 4f1fa7e4 on d10-plus