Component should be allowed to use the reserved "Elements" category

Created on 10 March 2025, about 1 month ago

Overview

Currently Components using "Elements" category are not allowed to be used. Fixing #3498419 📌 [Needs design] Library confusingly lists SDC-sourced and Block-sourced Components together Active removed this category, but the code has yet to be updated. @lauriii can you confirm that we no longer need to have this restriction in code?

Proposed resolution

In src/ComponentMetadataRequirementsChecker.php remove the following validation step:

    if ($metadata->group == 'Elements') {
      $messages[] = 'Component uses the reserved "Elements" category';
    }

Update tests accordingly.

User interface changes

📌 Task
Status

Active

Version

0.0

Component

Page builder

Created by

🇬🇧United Kingdom f.mazeikis Brighton

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @f.mazeikis
  • 🇬🇧United Kingdom f.mazeikis Brighton
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
  • 🇫🇮Finland lauriii Finland

    I agree, this is not needed anymore. 👍 Using the current heuristic of element being provided by XB is much better.

  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    IOW:

    • Do we want to keep this restriction? If so, we should update the message.
    • Do we want to remove this restriction, and allow SDCs to state they're in the "SDC group"? If so, how should this metadata get exposed? As the "elements" category for XB Components?
  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    Made the question for @lauriii more specific.

  • 🇫🇮Finland lauriii Finland

    Do we want to keep this restriction?

    I don't see why it would be needed anymore since we have the new way of determining elements.

    Do we want to remove this restriction, and allow SDCs to state they're in the Elements "SDC group"?

    Not right now. We should start by only allowing XB to provide elements. This way we don't have to manage dependencies to other modules from components built using elements. We may choose to change this later if we discover valid use cases to do this.

  • 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

    The two statements in #7 contradict each other.

    On the one hand, you say we don't need the restriction, on the other, you say we don't want to allow SDCs to be grouped under "elements".

    Please see the second bullet in #5. Each of those questions needs an answer.

Production build 0.71.5 2024