Problem/Motivation
When I have an entity reference field that references Content (nodes), and I configure the field to use a View as the reference method, and under Form display, I set the field widget to Draggable Table, when I save an entity (node) of this type after dragging items in the entity reference field, it will not set the values of the entity reference field, and so it will not save the deltas. The next time the entity is edited, the order of the table is reset, making the table drag useless.
Using a view in this way to set the values of a multi value field is core functionality, so it would be great if this module could support it.
Steps to reproduce
- Create a view of Content (nodes). Display only the title field. Ensure the view shows more than one result.
- Edit a different content type than the one displayed in the view and go the Manage fields tab. Add an entity reference field to Content. Under Reference type > Reference method, choose "Views: Filter by an entity reference view". Select your View in "View used to select the entities". Save the field.
- Continue editing the content type. Go to the Manage form display tab. Set the widget for the entity reference field to "Draggable Table". Save.
- Edit a node of the content type you added the entity reference field to. Reorder the field values by dragging them. Save.
- Edit the node again. See that the order you dragged the field values was not saved.
- You can verify this further by looking at the database table for the entity reference field and see that it has no values for the
entity_id of the node you've saved.
Proposed resolution
This can be fixed by removing one if statement from \Drupal\options_table\Plugin\Field\FieldWidget\OptionsTableWidget, although I'm unsure of the repercussions (if any).
This is what we have now:
public static function validateElement(array $element, FormStateInterface $form_state) {
$selected_options = [];
if ($element['#multiple']) {
foreach (Element::children($element['table']) as $item) {
if ($element['table'][$item]['enabled']['#value']) {
$selected_options[$element['table'][$item]['weight']['#value']] = $item;
}
}
}
If we change it to this, the field values are saved as expected:
/**
* {@inheritdoc}
*/
public static function validateElement(array $element, FormStateInterface $form_state) {
$selected_options = [];
if ($element['#multiple']) {
foreach (Element::children($element['table']) as $item) {
$selected_options[$element['table'][$item]['weight']['#value']] = $item;
}
}
This is because when using a View as the reference method, $element['table'][$item]['enabled']['#value'] is an empty string. $item in this case is the ID of the referenced entity.
Thinking about it, I'm unsure why we would check for $element['table'][$item]['enabled']['#value'], because doesn't the fact that the item is in the table at all indicate that it should be saved as a field value?
Remaining tasks
User interface changes
API changes
Data model changes