Error: Class "\Drupal\drd_agent\Crypt\Method\OpenSSL" not found

If you run your database update on the main site with DRD it will update all connection settings from OpenSSL to OpenSsl which is what's required.

Thanks for the fast response. The database update has already been carried out immediately after the update, on the main instance as well as on the projects. All updates were successful, so this must be a bug, right?

I can't think of anything anymore, because nothing is calling \Drupal\drd_agent\Crypt\Method\OpenSSL any longer, the class is now called \Drupal\drd_agent\Crypt\Method\OpenSsl. Only if the database update didn't succeed would there be a reference left to the old spelling. You can check that by looking into your database with the SQL query select domain,crypt from drd_domain;. Let's see what the crypt column tells you.

Thank you, I've checked the database from the main instance already:
SELECT crypt FROM `drd_domain`;
result OpenSsl

I've run cron multiple times, also run "drush cr", nothing helped... strange.

It gets even stranger, in \Drupal\drd\Crypt\Base::getInstance() I've logged the variable $method, and what does the log say?
'OpenSsl'

So at this point, the correct string is used.

Hmm, I'm running out of ideas then. I've had that same issue as I only updated my agents but not DRD on the main instance. When I realized that this was going wrong, I released DRD 4.1.7 and that fixed it. Maybe any legacy records in a queue somewhere?

If not, then only debugging may help to find out what exact request is being sent from DRD to the remote DRD Agent.

It gets even stranger, in \Drupal\drd\Crypt\Base::getInstance() I've logged the variable $method

So, that's on the DRD side. Maybe you can do something similar on the DRD Agent side?

So I have switched on the debug mode in the drd_agent project, I get this message:
"Input is incomplete"

The variable "$input" at line 270 in \Drupal\drd_agent\Agent\Action\Base::run() in /drd_agent/src/Agent/Action/Base.php:

Array
(
    [uuid] => string 36 characters
    [args] => 
    [iv] => string 24 characters
)

So no $args variable is available, which causes the message "Input is incomplete"

The request from the module drd on the main instance:

Array
(
    [0] => post
    [1] => https://example.com/drd-agent
    [2] => Array
        (
            [body] => string 120 charaters
            [headers] => Array
                (
                    [X-Drd-Version] => 1.7.0
                )

            [cookies] => GuzzleHttp\Cookie\CookieJar Object
                (
                    [cookies:GuzzleHttp\Cookie\CookieJar:private] => Array
                        (
                        )

                    [strictMode:GuzzleHttp\Cookie\CookieJar:private] => 
                )

        )
)

@jurgenhaas does that give you a clue as to what might be wrong? I have only updated the modules and updated the database.

I deleted the core of the project on the main instance, and reconnected it again with the agent. After that, I checked the variable "$method" at \Drupal\drd_agent\Crypt\Base::getInstance():
OpenSSL

So in the method \Drupal\drd_agent\Agent\Action\Base::getCryptInstance() the value $authorised[$uuid]['crypt'] is indeed "OpenSSL". I guess something went wrong with all the instances with the update of drd_agent including “drush updb” which was shown as successful.

To avoid investing even more time, it is probably best to uninstall the agent everywhere, reinstall it and then link all the projects again.

#10 helped not. Same issue.

In \Drupal\drd_agent\Agent\Action\Base::getCryptInstance(), the value of $authorised[$uuid]['crypt'] is always "OpenSSL". I have reinstalled everything several times, deleted and relinked core, with one exception, I have not uninstalled and reinstalled the drd module on the main instance.

@jurgenhaas Do you have any idea what's going on?

Ok so the problem is, the drd module core add form is not correct, I don't know why. I run composer remove drupal/drd and after that composer require 'drupal/drd:^4.1', so I'm sure it's the current version 4.1.7.

New added cores are saved wrong in the database (table drd_domain):

name = NULL
crypt = OpenSSL

First of all, as a first crypt settings on loading the add-core-page is this (but MCrypt is greyed out if i click on the select list)

After changing to OpenSSL:

Sounds like a great finding. I'm not back in the office before Thursday, so if you wanted to provide an MR I'd be happy to review and merge that first thing when I'm back.

So the final problem is the function \Drupal\drd\Crypt\Method\OpenSsl::getLabel():

  /**
   * {@inheritdoc}
   */
  public function getLabel(): string {
    return 'OpenSSL';
  }

Which is called in \Drupal\drd\Crypt\Base::getMethods():

  /**
   * {@inheritdoc}
   */
  public static function getMethods($instances = FALSE): array {
    $dir = __DIR__ . '/Method';
    $methods = [];
    foreach (['Mcrypt', 'OpenSsl', 'Tls'] as $item) {
      /* @noinspection PhpIncludeInspection */
      include_once $dir . '/' . $item . '.php';
      $classname = "\\Drupal\\drd\\Crypt\\Method\\$item";
      /** @var BaseMethodInterface $method */
      $method = new $classname(\Drupal::getContainer());
      if ($method instanceof BaseMethodInterface && $method->isAvailable()) {
        if ($instances) {
          $methods[$method->getLabel()] = $method;
        }
        else {
          $methods[$method->getLabel()] = [
            'classname' => $classname,
            'cipher' => $method->getCipherMethods(),
          ];
        }
      }
    }
    return $methods;
  }

Strictly speaking the part $methods[$method->getLabel()]

Solution: Change the getLabel() method of OpenSsl.php, Tls.php and Mcrypt.php or use the $item value.

I don't know with more recommended, but in a hurry I can only do it for patches. The adjustment must also be done on the agent side.

This is how it works for me again. But I have to link the projects again.

This is now pushed to DRD and DRD Agent, both in their latest dev release. Looking for another test.

@handkerchief there is an additional fix in 🐛 OpenSSL" not found Active that will help with this issue on remote sites so that you don't have to re-register remote sites with DRD.

@jurgenhaas I tested the new dev version of drd and drd_agent. Commit #16 of this issue is working, no more problems to add cores.

BUT your suggestion in #18 is not working. 🐛 OpenSSL" not found Active
The drd_agent update 8002 was successful, but a "drush drd-ping" from the main instance results in "Input is incomplete" (with drd_agent debug mode on). Reason: The $input variable at line 270 in /drd_agent/src/Agent/Action/Base.php has an empty $input['args'] parameter. I don't know why. So the only workaround right now is to re-register all remote sites so you get a new token with the correct values/parameters.

Looks like, somewhat similar to what is done in the drd_agent state and in drd_update_8008(), we need to update the relevant keys in the cryptsetting-field in the drd_domain table.
Some iteration on stored domains to update OpenSSL => OpenSsl.
I can have a closer look in the morning.

I've given the MR here a round of testing in top of the 4.1.x branch in combination with the drd_agent 4.1x branch

Gathering patches for dependencies. This might take a minute.
  - Upgrading drupal/drd_agent (4.1.2 => dev-4.1.x ab72fef): Checking out ab72fefab1 from cache
  - Upgrading drupal/drd (4.1.6 => dev-4.1.x d6232f7): Checking out d6232f774f from cache

After applying the relevant db updates the connection between drd and drd_agent appear to be maintained as expected:

$ drush updb
 ----------- ----------- --------------- --------------------------------------------------------------------------- 
  Module      Update ID   Type            Description                                                                
 ----------- ----------- --------------- --------------------------------------------------------------------------- 
  drd         8008        hook_update_n   8008 - Update crypt class names.                                           
  drd         8009        hook_update_n   8009 - Update crypt class names stored as keys in the cryptsetting field.  
  drd_agent   8002        hook_update_n   8002 - Update stored crypt methods after 4.1.3 update.                     
 ----------- ----------- --------------- --------------------------------------------------------------------------- 

$ drush drd:ping
Executing Ping
==============
- on id 1: Drush Site-Install
-----------------------------
 ! [NOTE] drd_action_ping [drd_domain/1]: Success with response Drush Site-Install {"data":"pong"}                                                                                          
 [OK]   ok!                                                                                                             
  pong
 [OK] Completed!                                                                                                        

This looks great, thanks @jfauske for your help on this one.