- Issue created by @cmlara
- Merge request !117Issue #3511840: TfaPluginManager should use ConfigFactory not ImmutableConfig → (Merged) created by cmlara
Automatically closed - issue fixed for 2 weeks with no activity.
The TFAPluginManager stores config as an ImmutableConfig into a property.
This is an anti-pattern causing a read of 'tfa.settings' when it may not be needed and prevents updates to config after the service is initialized from being readable.
Kernel Test:
$this->assertArrayNotHasKey('tfa_test_plugins_send_false', $tfa_pm->getSendDefinitions(TRUE));
$this->config('tfa.settings')
->set('send_plugins', ['tfa_test_plugins_send_false' => 'yo'])
->save();
$this->assertArrayHasKey('tfa_test_plugins_send_false', $tfa_pm->getSendDefinitions(TRUE));Move config_factory to a property and cease use of $tfaSettings.
None
Internal only class.
None
Active
2.0
Code
Automatically closed - issue fixed for 2 weeks with no activity.