Use injected entity query in storage classes

Open on Drupal.org →

Created on 9 March 2025, about 1 month ago

Right now both VoteStorage and VoteResultStorage use \Drupal::entityQuery() to calculate values, instead of using the injected entity query inherited from the parent storage class.

Fix this, and remove the phpstan ignore cases for these uses from phpstan.neon.

📌 Task

Status

Active

Version

4.0

Component

Code

Created by

🇺🇸United States tr Cascadia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!54Use injected entity query in storage classes
Merged
🇺🇸United States tr
updated 29 days ago

Comments & Activities

Issue created by @tr
Comment about 1 month ago →
🇺🇸United States tr Cascadia
Also type hint everything in the storage classes.
Merge request !54Resolve #3511838 "Use injected entity" → (Merged) created by tr
Comment about 1 month ago →
🇺🇸United States tr Cascadia
Pipeline finished with Skipped
29 days ago
#445189

Comment 29 days ago →

tr → committed 010514d0 on 4.0.x

Issue #3511838 by tr: Use injected entity query in storage classes

Comment 29 days ago →
🇺🇸United States tr Cascadia
Comment 15 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024