Add branches to test 'profile' and 'theme' project types

Good point. Profiles or themes are not the main target of the templates, but they are used by them for coding standards and various other checks, so yeah, we can check some minimal integration.

We should use the variable created in ✨ Try to remove most of the hardcoded "/custom" paths and use DRUPAL_PROJECT_FOLDER to calculate the right ones Active to install the right project type in the right folder.

I had this on my list of things for GTD, but it has now come to the fore given the latest changes in MR334

I have pushed a new branch named d10-theme
https://git.drupalcode.org/project/gitlab_templates_downstream/-/tree/d1...

The pipeline ran
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...

Can we add anything to it, to make it do things that a theme does, which are different from a module?

Thanks for adding it. Not sure really what things could be different, but they can defo have tests as modules. I think changing the installation path and running a default and simple set of jobs is a good beginning in any case. We can always add cases as they present themselves.

Manual test of BEFORE_SCRIPT_ACTIONS: cspell-use-madeupword phpcs-fail worked as expected
https://git.drupalcode.org/project/gitlab_templates_downstream/-/pipelin...

I also committed DRUPAL_PROJECTS_PATH: themes/custom as a permanent variable in the .gitlab-ci.yml

I have looked at a few themes and I don't think they use a composer.json. I could not find a way to use the search but limit it to themes.

Maybe this search gives more relevant results: https://git.drupalcode.org/search?group_id=2&repository_ref=main&scope=b...

Thanks for that. I added bootstrap ^3 and stable ^2 into the composer.json requirements. Bootstrap is good because it also needs the jquery_ui module, so this tests the download locations for both themes and modules. Here is the composer job artifacts - web directory run without MR334.

1. 'modules/contrib' has jquery_ui (good)
2. 'modules/contrib' has this gtd theme (incorrect, should be in themes)
3. 'themes' has 'bootstrap' and 'stable' (incorrect, needs 'contrib' sub-folder)

2 and 3 demonstrate the problem we are solving in MR334.

and here is a run using this MR as the downstream branch from MR334
https://git.drupalcode.org/issue/gitlab_templates_downstream-3511568/-/j...

1. 'modules/contrib' still has jquery_ui
2. 'modules/custom' no longer exists, as it is not used and 'themes/custom' contains this GTD theme (fixed)
3. 'themes/contrib' has 'bootstrap' and 'stable' (fixed)

I think this shows that the change to expand_composer_json is working as intended. It works for themes, so there is no reason it wont for profiles. (but we will get a profile branch in the project in due course)

The changes look good! RTBC.

Thanks. Merged.

Automatically closed - issue fixed for 2 weeks with no activity.