SamlauthUserSyncEvent::isAccountChanged() returns null by default

Created on 28 February 2025, about 1 month ago

Problem/Motivation

The documented return type is bool, but it's actually NULL by default.

Steps to reproduce

In a test:

$this->assertFalse($event->isAccountChanged());

Proposed resolution

Cast the return type to bool/initialize it to FALSE.

Strict types would help, but kind of a BC break if you support subclassing those event classes.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024