ConfigTranslationController::itemPage() does not specify cacheable metadata

Created on 28 February 2025, about 1 month ago

Problem/Motivation

Discovered in #3437499-65: Use placeholdering for more blocks .

If we stop putting the local tasks block on the page (due to placeholdering), the page becomes stale. This means we did not specify all the dependencies correctly. We should add the cacheable metadata of the access checks and the config objects being translated to the page.

Steps to reproduce

Run the ConfigTranslationUiModulesTest in the other issue and see that it fails if we do not fix ConfigTranslationController.

Proposed resolution

  1. Split off the fix from the other issue to this one so that it has a dedicated issue explaining the problem.
  2. Do not add extra tests as the test failure in the other issue shows that tests are sufficient, they just had their results masked by the fact that the local tasks block contained the expected cacheable metadata rather than the actual page.

Remaining tasks

None, will post MR with cherry-picked commits ASAP.

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

config_translation.module

Created by

🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024