TypeError : count(): Argument #1 ($value) must be of type Countable|array, null given dans _workflow_transition_form_get_action_buttons()

There is a warning related too.

Warning : Undefined array key "#options" in _workflow_transition_form_get_action_buttons() (web/modules/contrib/workflow/workflow.form.inc line 126)

Thanks

I tried the lastest dev version (c673e35f0b) and error change :

UnhandledMatchError : Unhandled match case true dans Drupal\workflow\Entity\Workflow->getStates() (line 357 of web/modules/contrib/workflow/src/Entity/Workflow.php).

With latest dev version (661a38d65d). The initial problem is coming back :
TypeError : count(): Argument #1 ($value) must be of type Countable|array, null given in _workflow_transition_form_get_action_buttons() (line 131 de web/modules/contrib/workflow/workflow.form.inc)

Hmm , I do not really understand how this could happen, other than having a Workflow type without states.
Do you have a specific contellation that triggers the problem?

I should not occur in current dev, since the lists are properly initialized.
Anyway, I will add a safeguard in workflow.form.inc

Please repond, even if the issue status is 'fixed'.

I have 3 states in my workflow but I have only actions buttons displayed in my node form.

Above patch make sure you cannot hide the 'To state' subfield. on the Workflow's 'Manage form display page'.

I just updated code but I still have an error when accessing my node form :
TypeError : Drupal\workflow\Element\WorkflowTransitionElement::updateWidget(): Argument #1 ($haystack) must be of type array, null given, called in /web/modules/contrib/workflow/src/Element/WorkflowTransitionElement.php on line 194 in Drupal\workflow\Element\WorkflowTransitionElement::updateWidget() (line 273 of web/modules/contrib/workflow/src/Element/WorkflowTransitionElement.php).
Thanks for your help.

Hi, This is because you have hidden all fields in the Workflow ' Manage Form Display'.
If you now try to save that page, you will get an error, and the field will be displayed.
Thisis necessary, because the widget carries information, and is not hidden, but converted.

Hi,
When I try to save the manage form display page, I have an error :
Error : Cannot access protected property Drupal\Core\Entity\Entity\EntityFormDisplay::$targetEntityType in Drupal\workflow\Hook\WorkflowEntityHooks->entityPresave() (line 71 of web/modules/contrib/workflow/src/Hook/WorkflowEntityHooks.php)
But no field are displaying. I tried to put to state field active and save but I have the same error.

I do not get the error, but found an appropriate function to use.
See fix in 📌 Introduce class WorkflowTargetEntity Active .
Buta I guess you wil get another error on the next line.
I use PHP8.3 and D11.2.
What versions do you use?

With the last code update, previous error disappeared ! I reactivated the to state field in the manage form display page and save without error too. Now I can access my node form without the initial error !
Nevertheless, I have a new action button at end of node form with the label "choose a value" and others button actions corresponding to my worflow states. Is it normal to have this new action button ? As what I need is to display only buttons corresponding to my states as before !

I do not see that strange button om my systeem. Which Theme are you using?
I Will check where this New button is generated.

I use olivero theme. My workflow parameters are : No fieldset, display states with action buttons and comment field hide.
Thanks for your help.

When I tried to delete a user, there is an error :
ArgumentCountError : Too few arguments to function Drupal\workflow\Hook\WorkflowEntityHooks::userDelete(), 1 passed in web/modules/contrib/workflow/workflow.entity.inc on line 77 and exactly 3 expected dans Drupal\workflow\Hook\WorkflowEntityHooks->userDelete() (line 225 of web/modules/contrib/workflow/src/Hook/WorkflowEntityHooks.php)

This shows that the module badly lacks tests....

re: comment #18 above- I had seen this too, and have a fix that I'll share. However, it looks to me like that is a separate issue from the one reported here, so I'll start a new one for it :)

Regarding the user delete (#18), that is now fixed in another issue from #20.
Regarding the initial issue, that should be fixed, the function is now addActionButtons().
Regarding the "choose a value" (#15), please run update.php. The version 1.8 and current dev is trying to leverage the standard core code via baseFieldDefinitions(). The 'required' is now set in the BaseField.

Thanks to have correcting this bug !

Automatically closed - issue fixed for 2 weeks with no activity.