js_component examples and enum do not respect the prop type

got it started. add comment about needed test coverage. It seems like `\Drupal\experience_builder\Entity\JavaScriptComponent::normalizeForClientSide` is the right place but maybe we want to refactor that into another method.

Do we need to validate that only integers and numbers are sent in the request if that matches the type?

This can actually be seen in \Drupal\Tests\experience_builder\Functional\XbConfigEntityHttpApiTest::testJavaScriptComponent

Great catch!

Another missed defect in ✨ HTTP API for code component config entities Active (actually even before that, in ✨ Config entity for storing code components Active , but there it was less obvious than the literally incorrect example in the test that @tedbow quoted in the issue summary 👍).

Looking at your analysis so far, I wonder if this is actually a pure config schema problem 🤔

Yep, confirmed: this is a pure config schema problem. It's quite interesting, really: we need to describe in config schema , for the subset of it that XB supports. 🤓🤯😄

Tests + fixes incoming.

1. Test coverage complete (functional + kernel), and it revealed quite a list of broken things: https://git.drupalcode.org/project/experience_builder/-/jobs/4484811
2. One of the wildest things I've ever done: expressing the supported subset of JSON Schema in Drupal's Config Schema: https://git.drupalcode.org/project/experience_builder/-/merge_requests/7... 🤯 🤓 This automatically fixes the problem reported here, but also provides much more precise validation errors, and removes the need to perform manual typecasting.

The stricter validation this introduces even uncovered multiple test coverage bugs that @f.mazeikis and I missed in ✨ Allow adding image properties in the code editor Active yesterday! 😱🥳

P.S.: This is what I was hoping/expecting to see on ✨ Config entity for storing code components Active , but didn't ask for/block it on because it'd have delayed all of 🌱 [Meta] Plan for code components Active .

CI agrees! (component-operations.cy.js fails on CI, but passes locally. It's been a known fairly frequent random failure for a while.)

I'd like @tedbow to do final sign-off given he started this MR and I took it in a very different direction.

Also, I bet that @tedbow's 🐛 Javascript code components props, examples and description should be optional Active (which just landed) conflicts with this.

I also tested this, and the problem it caused its gone. I'll leave it up to you if this is ready to be merged.

a couple small things

All addressed 👍 Some nice catches, @tedbow — thanks!

@balintbrews Thanks for explicitly testing this indeed fixes the consequences in the UI! 🙏👍

Automatically closed - issue fixed for 2 weeks with no activity.