Clicking on the tasks button doesn't close open sidebar when big_pipe module is enabled

Created on 26 February 2025, about 2 months ago

Problem/Motivation

When clicking on the task button when the moderation sidebar is open the sidebar doesn't close. Instead it closes briefly and then re-opens.

This only happens when the big pipe module is enabled. If I disable the big pipe module clicking on the task button will close the moderation sidebar and it will stay closed. Doing some research shows that big pipe made massive changes to its Javascript event handling in Drupal 10.3 which now cause some JQuery events to fire twice, this may be what's happening here.

Note that I've also installed the patch from this issue to prevent the tasks menu from redirecting (which may also be a consequence of the big pipe module): https://www.drupal.org/project/moderation_sidebar/issues/3483342 🐛 Js bug when double click on Quick Edit Needs work

This is happening under Drupal 11, but I suspect it started happening around Drupal 10.3.

Steps to reproduce

Have a Drupal site with some nodes with workflows already setup.

1. Log in as an administrator (just for ease of testing, this happens on any user with editing permissions)
2. Enable the core big pipe module
3. Enable the core admin toolbar module
4. Install the moderation sidebar module but don't enable it just yet
5. Apply the patch from https://www.drupal.org/project/moderation_sidebar/issues/3483342 🐛 Js bug when double click on Quick Edit Needs work to the moderation sidebar module
6. Enable the moderation sidebar module
7. Navigate to a node with the workflow.
8. Click on the tasks button to open the moderation sidebar
9. Click on the tasks button again.

What should happen:
- The open moderation sidebar should close (same as if we clicked on the X button)

What is happening:
- The sidebar closes but then immediately opens again, as if the button had been clicked twice.

🐛 Bug report
Status

Active

Version

1.8

Component

Code

Created by

🇦🇺Australia demma10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024