If there is an error during activation, the project should not show the "Installed" indicator

Let's start with a test first here; it might have been incidentally fixed by 📌 Move load() function of ProjectBrowser.svelte into a new window-scoped class Active . But we should have a test either way!

I've confirmed with manual testing that this bug persists even after 📌 Move load() function of ProjectBrowser.svelte into a new window-scoped class Active , so it didn't get fixed incidentally.

Let's get a test going!

To help with fixing the actual bug, I think the problem is probably this bit of InstallListProcessor.js:

  for (const project of currentInstallList) {
    if(!project.error) {
      project.status = 'active';
    }
  }

There are a couple of things wrong with this.

1. It's checking for project.error value which is not defined from the backend and never exists.
2. It assumes that if the activation request finished at all, the project is installed.

I suspect that just deleting this bit will, by itself, fix the bug. But we still need a test.

Confirmed in manual testing that the bug is indeed fixed by deleting that snippet. There's our fix!

And, test written. :)

The test is catching the bug: https://git.drupalcode.org/issue/project_browser-3508971/-/jobs/4508043#...

This is completely ready for review. Assigning to @chrisfromredfin for that!

yessireebob

Automatically closed - issue fixed for 2 weeks with no activity.