Errors are not properly caught

Created on 25 February 2025, about 2 months ago

Problem/Motivation

While the module catches Exceptions, it does not catch Errors, which albeit less common can still happen.
It is important to properly handle them, or we risk site versions in broken states, which we've seen in a few cases.

Steps to reproduce

Throw an Error during the publishing (or unpublishing, archiving and restoring) and note how the changeset remains in an undefined, and fundamentally broken, state.

Proposed resolution

Catch Throwable instead of Exception.
The suggested patch also cleans up the handling in the different cases.

Remaining tasks

Testing.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

🇮🇹Italy marco

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024