- Issue created by @webmestre
- ๐บ๐ธUnited States amstercad
Thank you for your use of my code and for bringing this issue to my attention. I'm looking into this matter today.
- ๐บ๐ธUnited States amstercad
So far, when testing using Drupal CMS I am not able to reproduce the bug. I haven't had time to test using straight-up Drupal core yet. But I always test with a clean install and only with required modules. I'll adjust my development next week to test things using Drupal core.
If anyone else has the bug, please let us know.
- ๐น๐ผTaiwan yelban
Since @videojs/themes hasnโt released any new updates to fix this, and npm audit fix really canโt do much about these "transitive dependency" vulnerabilities, Iโm wondering if we could just ditch @videojs/themes altogether or maybe switch to a different Video.js theme approach? What do you think?
- ๐บ๐ธUnited States amstercad
Yelban, that's quite a hack you are suggesting. What does this accomplish? Is the SDC display effected? The libraries are installed according to VideoJS documentation. @videojs/themes is pulled in via core VideoJS libraries.
Done this way,
npm up
always pulls in the latest version of everything. - ๐น๐ผTaiwan yelban
Amstercad, Thank you for creating this excellent module! When running `npm install` in `./videojs_mediablock`, npm reported 5 vulnerabilities (2 moderate, 3 high). Unfortunately, these couldn't be fixed with `npm audit fix`. Even adding resolutions to `package.json` didn't help due to the locked dependency on an older version of `@videojs/themes`.
"resolutions": { "postcss": "^8.4.31", "css-select": "^4.0.0", "nth-check": "^2.0.1", "postcss-inline-svg": "6.0.0", "@videojs/themes/postcss-inline-svg": "^6.0.0" }
It seems that `@videojs/themes` pulls in an outdated `postcss-inline-svg@4.1.0`, which itself depends on `postcss@7.x` and `css-select@2.x`. As a result, my attempts at overriding via resolutions were unsuccessful.
After briefly reviewing the module's source code, I thought about removing the installation of `@videojs/themes` altogether. However, I'm unsure if deleting `@videojs/themes` might cause other issues. Therefore, I wanted to ask for your advice before proceeding. :)
- ๐บ๐ธUnited States amstercad
Yelban, you make an excellent point, however I don't think this is the best forum for this issue. I think the VideoJS forum at Github is more appropriate.
Please cross post here, so we can follow what happens over there.