- Issue created by @msypes
- π¬π§United Kingdom aaron.ferris
aaron.ferris β made their first commit to this issueβs fork.
- Merge request !10Issue #3508556: dont render a disabled menu item β (Merged) created by aaron.ferris
- π¬π§United Kingdom aaron.ferris
I could well be missing something, but this appears to be because of the change to this condition
Before
if (NULL !== $menu_item->link && !($menu_item->link instanceof InaccessibleMenuLink) && $link['enabled']) {
After
if ($menu_item->link instanceof InaccessibleMenuLink && !$link['enabled']) { continue; }
What im seeing, at least in my project, is that the top level menu item is not an instance of InaccessibleMenuLink but is not enabled, but won't ever fall into this condition because they're both not true.
Raised an MR that seems to fix this for me.
- π¬π§United Kingdom opsdemon
Upgraded to 8.x-1.9 today and I am also seeing this issue.
The disabled top-level menu items are now being displayed.
We do not see this issue with version 1.8.
- First commit to issue fork.
-
lobsterr β
committed 9547495a on 8.x-1.x authored by
aaron.ferris β
Issue #3508556: Disabled menu items displayed
-
lobsterr β
committed 9547495a on 8.x-1.x authored by
aaron.ferris β
-
ivnish β
committed b1e494fa on 2.0.x authored by
aaron.ferris β
Issue #3508556: Disabled menu items displayed
-
ivnish β
committed b1e494fa on 2.0.x authored by
aaron.ferris β
- π¬π§United Kingdom opsdemon
I tested the new release 1.10 and can confirm that the problem is fixed.
Automatically closed - issue fixed for 2 weeks with no activity.