- Issue created by @bbrala
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This looks great. I'm not sure about the
FullyValidatable: ~
here, I think this only applies on a root object, and I'm not sure that plugins can be. I'll look through core to see if other plugins are already marked like this.This also needs a test, EntityBundleExistsConstraintValidatorTest is a good starting point for this.
- 🇳🇱Netherlands bbrala Netherlands
Ty!
For jsonapi to accept posting/patching this, it needs to be flagged as fullyvalidatable. That is how i got here, trying to enable system.action tests in jsonapi.
I saw the test you mentioned, I'll use that as a base. Just wanted to validate me understanding how to do this.
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Adding tags to make this issue discoverable. I tried converting this to the template we use for the other issues, but I don't find a way with config inspector to surface this easily.
- 🇳🇱Netherlands bbrala Netherlands
Perhaps this will help getting overviews for such things: ✨ Support glob style filter in filter-keys Active
- 🇳🇱Netherlands bbrala Netherlands
Added a test for the validation. Removed an extra comment and added possible follow up ✨ [Follow-up] action.configuration.user_remove_role_action could also use a UserHasRole constaint Active
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This looks great, it has testcoverage, because we have the followup to the UserHasRole constraint I think we can commit this as-is, so we can keep both issues small and focussed.