Unexpected empty subtree error

AFAICT this is a bug in ClientServerConversionTrait, because the semantics are different.

The error originates from

      new Count(['min' => 1], minMessage: 'Empty component subtree. A component subtree must contain >=1 populated slot (with >=1 component instance). Empty component subtrees must be omitted.'),

in ComponentTreeStructureConstraintValidator.

I just removed the constraint and quickly removed the test expectations. Not sure if the tests will all pass. also need to see if we need any new test cases

Why remove the constraint? Why not instead modify ClientServerConversionTrait and add an explicit test for handling this in ClientServerConversionTraitTest? 🤔

tedbow → closed merge request !718

👍 — but can we add a (tiny) test for this? 🙏

@wim leers I added another component to the existing \Drupal\Tests\experience_builder\Kernel\ClientServerConversionTraitTest::testConvertClientToServer

But also noticed this doesn't have tests for slots that filled so I will add that here too.

Test coverage looks solid 👍

Will merge this, assuming the test-only CI run fails as expected.

Automatically closed - issue fixed for 2 weeks with no activity.