- Issue created by @tgauges
- 🇬🇧United Kingdom scott_euser
So your case is where you created both?
In most cases I expect people actually want it to get maintained so rather than creating unique, maybe only make it unique if the target of the change already exists?
- 🇩🇪Germany tgauges
@scott_euser
yes, this is for when both types of filters exist.
\Drupal\views\ViewExecutable::generateHandlerId
does exactly that: It only changes the ID if it is not unique. - 🇬🇧United Kingdom scott_euser
Makes sense, thanks! I'll give it a play as soon as I can.
- 🇬🇧United Kingdom scott_euser
This looks fine thanks! Just needs phpcs fixes (minor) and test fixes.
For the teset fixes, it seems the source yml in the new field you added contains the attributes of the entity reference plugin yet is marked as 'numeric' plugin which I believe is what is causing schema errors.
- 🇩🇪Germany tgauges
Thanks for the hint regarding the numeric plugin. I fixed the issues and the MR can be reviewed.
- 🇬🇧United Kingdom scott_euser
Thanks! This looks good; I would resolve merge conflicts myself from your other issue, but a bit nervous I'll break things - hope you don't mind this last step.
Thank you
- 🇩🇪Germany tgauges
I merged the current 1.0.x-Branch into the issue branch and updated a comment, please review :)
-
scott_euser →
committed adb65e14 on 1.0.x authored by
tgauges →
Issue #3506791 by tgauges: Do not override existing filters in automatic...
-
scott_euser →
committed adb65e14 on 1.0.x authored by
tgauges →