ViewExecutable should not be responsible for parsing exposed input

Created on 14 February 2025, about 2 months ago

Problem/Motivation

ViewExecutable always looks for exposed input in the session and query parameters, even if the view itself does not have any exposed filters and whether or not the 'remember' setting is. Then it stores it on a $this->exposed_input property.

All this logic does is get things out of the request (query or session), I think that logic could be moved to the places that need it, and then deprecate the ::getExposedInput() and ::setExposedInput() methods once they aren't called in core.

If it's repetitive, we could move it to a helper somewhere but without maintaining the state.

Opening as a bug report because I think that is a view is configured to remember exposed input in session, and then is configured not to remember exposed input in session, that users who previously filtered the view would still get their session contents applied, which seems very wrong.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

🐛 Bug report
Status

Active

Version

11.0 🔥

Component

views.module

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024