Contrib.social

Remove unnecessary override of block--system-menu-block.html.twig

Open on Drupal.org →
Created on 12 February 2025, 6 months ago

Problem/Motivation

templates/block/block--system-menu-block.html.twig seems like it is unnecessary overridden.

The only meaningful difference between bootstrap5's version of that file and core/modules/system/templates/block--system-menu-block.html.twig is that bootstrap5's override changes the title element from a <h2> to a <h5>. Semantically it should be a h2 like core does it (a Lighthouse report on "Heading elements are not in sequentially-descending order" was led me to create this issue in the first place).

The only other difference with core is the classes being added to the wrapping <nav>, but they seem unneeded as they were removed from core in #2407715: Remove classes from system templates b*.html.twig → .

The original override of block--system-menu-block.html.twig happened way back in #3025596: Add ability to switch between fixed and fluid global layouts. → , i.e. from the bootstrap4 repo.

Steps to reproduce

Proposed resolution

Remove bootstrap5's version of templates/block/block--system-menu-block.html.twig

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

4.0

Component

Code

Created by

🇦🇺Australia fenstrat Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024