Warning: filefield_source_remote_curl_write(): Argument #1 ($ch) must be passed by reference

PHP 8.0 Fix for:

Warning: filefield_source_remote_curl_write(): Argument #1 ($ch) must be passed by reference, value given in filefield_source_remote_value() (line 256 of /sites/all/modules/contrib/filefield_sources/sources/remote.inc).

Replace the following starting at line 238:

    if (isset($file_contents)) {
        if ($fp = fopen($filepath, 'w')) { // Removed @
            fwrite($fp, $file_contents);
            fclose($fp);
            $transfer_success = TRUE;
        } else {
            $transfer_success = FALSE;
            error_log("Failed to open file for writing: $filepath");
        }

    // If we don't have the file contents, download the actual file.

    } else {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_HEADER, FALSE);
        curl_setopt($ch, CURLOPT_WRITEFUNCTION, 'filefield_source_remote_curl_write');
        // Causes a warning if PHP safe mode is on.
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, TRUE); // Removed @ - handle redirects manually if needed
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE); // Essential for capturing the result
        // Set a user agent - some hosts block requests unless header is present.
        $curl_version = curl_version();
        curl_setopt($ch, CURLOPT_USERAGENT, 'PHP-curl/' . $curl_version['version']);
        $file_contents = curl_exec($ch);
        if ($file_contents === FALSE) {
            $transfer_success = FALSE;
            error_log("cURL Error: " . curl_error($ch));
        } else {
            $transfer_success = TRUE;
            if ($fp = fopen($filepath, 'w')) {
                fwrite($fp, $file_contents);
                fclose($fp);
            } else {
                $transfer_success = FALSE;
                error_log("Failed to open file for writing: $filepath");
            }
        }
        curl_close($ch);
    }

    $item = []; // Initialize $item

    if ($transfer_success && $file = filefield_sources_save_file($filepath, $element['#upload_validators'], $element['#upload_location'])) {
        $item = (array) $file; // Cast to array if needed to be absolutely certain. If you know the return is already an array, this is unnecessary.
    }

    // Delete the temporary file.

    if (isset($item['uri']) && $filepath !== $item['uri']) {
       if (!unlink($filepath)) {
       error_log("Failed to delete temporary file: " . $filepath); // Or your preferred error handling
       }
    }
  }
}

Disclaimer: Generated from Google Gemini