Contrib.social

Payments are not transitioning correctly

Open on Drupal.org →
Created on 11 February 2025, 2 months ago

Problem/Motivation

We ran into this lately where payments are paid but where not transitioning into the right state. This was caused since we made a onNotify call for payments where the remote state was open. We do this cause sometimes mollie could not update the order after trying for 22 hours and then we need to retry it (see https://docs.mollie.com/reference/webhooks#retry-schema). And since the onNotify method is public we need to keep in mind anyone could call this method multiple times.

For example: we saw orders that were tried to move from the state 'completed' to 'authorization_capture' or from 'authorization' to 'authorization_capture'. Which is not possible when we follow the modules/contrib/commerce/modules/payment/commerce_payment.workflows.yml flow.

Normally Mollie doesn't call the onNotfiy method for open orders but it does multiple times for completed orders. The current code in Mollie.php doesn't support for multiple calls on the onNotify, this issue contains an patch that will support mulitple calls.

Besides the support for multiple calls is there is the following issue, not all paid orders from mollie could be put in 'authorization_capture' flow. This would require that all orders that go through that flow would transition from the 'new' state to 'paid'. While it could be possible that the order is in an 'authorization' state. In my code change i added an check which requires the orders to first move in an authorization state and only then we can move orders to an final state.

Steps to reproduce

call the onNotify method twice. For example with an order wich has the status paid.

Proposed resolution

  • Check if we need to update the state and the remote state.
  • Only update states when necessary
  • Support for multiple calls since the onNotify method is public
  • When orders are paid its necessary to only capture the payment instead of the transition_capture since open payments are now in an transition state
🐛 Bug report
Status

Active

Version

1.10

Component

Code

Created by

🇳🇱Netherlands thomas wijnands

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024