Core marked any entity form as uncacheable (max-age = 0) in
📌
Form tokens are now rendered lazily, allow forms to opt in to be cacheable
Needs review
and this will be fixed in
📌
Make entity forms cacheable
Active
.
However, after upgrading to Drupal 11 and seeing the flow on effects on our projects, I think we should manually remove this max-age in WebformSubmissionForm.
If you are using Webform on Drupal 11 with https://www.drupal.org/project/cache_control_override → you will get pages without a max-age set in the Cache-Control header resulting in pages being uncacheable by the CDN (bad).
WebformSubmissionForms are cached in D10.4 and I don't think any of the issues that 📌 Make entity forms cacheable Active will tackle will really apply to Webforms.
Install Webform on D11
Install cache_control_override
Create a page with a webform on it
Notice Cache-Control headers are set to no-cache
Do a unset($form['#cache']['max-age']); after $form = parent::form($form, $form_state); in WebformSubmissionForm::buildForm
Active
6.3
Code
Gonna be a bit trickier than I first expected by the looks of the test failures. It seems like some things perhaps aren't setting the cacheable metadata that they should be on Webform's end and were just coincidentally passing before.