Contrib.social

PHPUnit deprecations: data provider methods should be static

Open on Drupal.org →
Created on 10 February 2025, 2 months ago

Problem/Motivation

Running phpunit --display-phpunit-deprecations on PHPUnit 10 returns...

2 tests triggered 2 PHPUnit deprecations:

1) Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\FilterBuilderTest::testBuildFilterTerm
Data Provider method Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\FilterBuilderTest::filterTermProvider() is not static

/var/www/html/tests/src/Unit/SearchAPI/Query/FilterBuilderTest.php:115

2) Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\SearchParamBuilderTest::testBuildSearchString
Data Provider method Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\SearchParamBuilderTest::buildSearchStringDataProvider() is not static

/var/www/html/tests/src/Unit/SearchAPI/Query/SearchParamBuilderTest.php:86

Steps to reproduce

  1. Follow the documentation for setting up a local environment for testing → — at time-of-writing (2025-02-10), it installed Drupal 11.1 and PHPUnit 10
  2. Run phpunit --display-phpunit-deprecations

Proposed resolution

Make \Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\SearchParamBuilderTest::buildSearchStringDataProvider() and \Drupal\Tests\elasticsearch_connector\Unit\SearchAPI\Query\FilterBuilderTest::filterTermProvider static

Remaining tasks

  1. Write a patch
  2. Review and feedback
  3. RTBC and feedback
  4. Commit
  5. Release

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Active

Version

8.0

Component

Code

Created by

🇨🇦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024