WYSIWYG install error after core 10.4.2 upgrade

Patch is attached.

Thanks! Merged :-)

Automatically closed - issue fixed for 2 weeks with no activity.

I think this needs reopening, the patch is not fixing the issue.

/**
 * Implements hook_modules_installed().
 */
function panopoly_wysiwyg_modules_installed(array $modules) {

  user_role_grant_permissions('anonymous', [
    'use text format restricted_html',
  ]);
  user_role_grant_permissions('authenticated', [
    'use text format restricted_html',
    'use text format panopoly_wysiwyg_basic',
  ]);
  user_role_grant_permissions('editor', [
    'use text format restricted_html',
    'use text format panopoly_wysiwyg_basic',
  ]);

}

Unfortunately this is not how hook_modules_installed works. The hook for panopoly_wysiwyg doesn't run when panopoly_wysiwyg is installed, it runs when any module is installed after panopoly_wysiwyg.

Instead the hook should probably be moved to panopoly.install and specifically look for panopoly_wysiwyg. If anyone's using the module without the install profile, they can grant the permissions in some other way. New patch forthcoming.

New patch is attached.