Implement strict typing in existing code

Created on 8 February 2025, about 2 months ago

As per the core issue 🌱 [Meta] Implement strict typing in existing code Active

We have already done this in the tests, but now let's complete the job and do it for all the code in this module.

πŸ“Œ Task
Status

Active

Version

4.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @tr
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    And the failed test shows exactly why it is so important to use strict typing (and why it is important to have working tests like we now do!) - somewhere in the code we have "energy" being passed around as a string instead of a float. That error was being hidden due to PHP type coercion taking place when strict typing was disabled.

  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    Mmm ... cascading failures. I might have to back off and only use strict types for part of the code for the time being, because fixing all the tests might prove too time consuming for now.

Production build 0.71.5 2024