Validation results should implement CacheableDependencyInterface

john.oltman → credited jonathanshaw → .

Shouldn't src/RegistrationValidationResult.php be implementing RefineableCacheableDependencyInterface not CacheableDependencyInterface?

Your change to the behavior of RegistrationValidationEventSubscriber::getCacheableMetadata looks like it break the behavior of registration_admin_overrides\EventSubscriber\RegistrationValidationEventSubscriber

I'm also not sure what that change does to the way the validator and constraint validators handle cacheability, but I imagine we have test coverage there.

Shouldn't src/RegistrationValidationResult.php be implementing RefineableCacheableDependencyInterface not CacheableDependencyInterface?

I've seen it done both ways, and it works as-is because I am using the trait, but AccessResult in core does what you suggest, and that is my model, so I will fix.

Your change to the behavior of RegistrationValidationEventSubscriber::getCacheableMetadata looks like it break the behavior of registration_admin_overrides\EventSubscriber\RegistrationValidationEventSubscriber

Indeed, good catch. I will fix and add a test for this code path.

Automatically closed - issue fixed for 2 weeks with no activity.