Hook Arguments ($form) must be passed by reference, value given

abhishek_gupta1 → made their first commit to this issue’s fork.

hook_honeypot_add_form_protection() and hook_honeypot_form_protections_alter() were added to the Honeypot module by #1778296: add hook in honeypot_add_form_protection → . That was back in 2012, in the Drupal 6 version!

When trying to use the HOOK honeypot_add_form_protection the values are not given by reference so you can't edit them

This is true. However, the hook signature is currently the same as it has always been, and has never changed. I don't think this can be considered a bug, because that appears to have been intentional. Regardless, that has always been the documented behavior ever since these hooks were first defined.

The problem with your proposed change is that swapping the order of the arguments will break any code that is relying on the "old" order. And allowing the form to be modified inside of hook_honeypot_add_form_protection() is also an API change, which may also break any code using this hook. To make this change properly, there would have to be a BC layer that accepted both the old and new parameter order, and also a @deprecated notice when this hook is called with the "old" order, to inform users of this hook that the parameter ordering has changed. There would also have to be tests for this change.

I guess the question I would ask is, why do you want to alter the form in this hook? And why wouldn't you use hook_form_alter()or some other method instead? I would be more inclined to accept a new, more logical and useful hook or hooks instead of trying to change the old hook.

We are now implementing it in a form_alter #after_build. We want to alter the generated honeypot field.

It seems logical to me that if there is an hook after adding the honeypot field you can also alter the honeypot field in the form. Using alter_form and check each form for the honeypot field seems a bit overkill since there is this hook.

But I agree with you that this is more a feature request.