Contrib.social

Remove stateContext from the Svelte code

Open on Drupal.org →
Created on 6 February 2025, about 2 months ago

Problem/Motivation

So there's thing in some parts of the Svelte code: stateContext. It's used in certain places, but those uses don't...actually seem to go anywhere, or be used for anything.

I strongly suspect that this was part of some earlier refactoring effort from the days of yore, to avoid passing global state around (a problem which is now significantly mitigated, although by no means fully fixed). As it is, this appears to be just a vestigial thing that only serves to clutter the Svelte code and make it confusing.

Proposed resolution

Remove it. If all tests pass with it gone, I think that's pretty strong evidence that it is not needed. This will continue the long quest to clean up the Svelte app and make it maintainable.

📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !709Remove stateContext and originalEvent → (Merged) created by phenaproxima
  • Comment about 2 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment about 2 months ago →
    🇺🇸United States phenaproxima Massachusetts

    The tests pass on my local machine, so I have reason to believe they'll pass on CI too.

  • Pipeline finished with Success
    about 2 months ago
    Total: 519s
    #417278
  • Pipeline finished with Success
    about 2 months ago
    Total: 388s
    #417299
  • Pipeline finished with Skipped
    about 2 months ago
    #417303
  • First commit to issue fork.
  • Comment about 2 months ago →
    System Message
  • Comment about 2 months ago →
    🇺🇸United States chrisfromredfin Portland, Maine

    baller

  • Comment about 2 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Canceled
    about 1 month ago
    Total: 64s
    #434707
  • Pipeline finished with Success
    about 1 month ago
    Total: 1250s
    #434708
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 332s
    #434826
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1465s
    #434832
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 813s
    #434856
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 811s
    #434864
  • Pipeline finished with Success
    about 1 month ago
    Total: 1278s
    #434872
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 1352s
    #434894
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 869s
    #434911
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 1330s
    #434927
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1293s
    #434958
  • Pipeline finished with Failed
    about 1 month ago
    Total: 1291s
    #435034
  • Pipeline finished with Success
    about 1 month ago
    Total: 1510s
    #435065
  • Pipeline finished with Success
    about 1 month ago
    Total: 1741s
    #435184
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024