- Issue created by @roderik
- Merge request !115Skip entity_type_alter until layout_builder_install() has executed → (Merged) created by roderik
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
This needs a review, because the code is 'ugly': I don't see a way to know that "layout_builder is being installed" without hardcoded assumptions. (And that's why the comments are big.)
I think we have no other options / it's fine.
- It errs on the "safe" side, being: only skip when it encounters the exact Layout Builder classname (while Layout Builder is not actually installed).
- This does mean: if the class is somehow renamed, the fatal error returns.
I checked the entity_type_alter behavior manually with xdebug enabled, and it does the expected thing:
- only skips while layout_builder is being installed
- works normally,
- at other moments during the 'drush en layout_builder' command
- in normal operations
- during install/uninstall of other modules, either with or without layout_builder enabled.
I only tested with drush. Since the only 'interaction' is with the ModuleInstaller service, drush vs UI install can't make a difference.
- First commit to issue fork.
- 🇦🇹Austria fago Vienna
tested it with lupus decoupled - this solves the problem! Code looks great also, thus merged!
Automatically closed - issue fixed for 2 weeks with no activity.