Modules that set messages aren't shown

Created on 5 February 2025, about 2 months ago

Problem/Motivation

Certain modules (TODO need example) set $messages in Drupal when their installer runs. In Project Browser, we should be able to show these messages after the installation completes successfully.

Steps to reproduce

Install a module that sets Drupal messages using Project Browser. (Note, the message is still in queue, so you see it when you navigate away to a new page, but at that point it's too disconnected from what caused the message to be set).

Proposed resolution

I believe we'll need to be able to poll for messages from Drupal after completing the installation task, and then display them using JS.

โœจ Feature request
Status

Active

Version

2.0

Component

User experience

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @chrisfromredfin
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    We have a clear pathway to doing this now.

    In InstallerController::activate(), as we build the AJAX response, we could pull all messages out of the messenger service and add them to the response with the MessageCommand.

    To test it, all we'd need to do is make TestActivator set a message or two in its activate() method when handing a specific (fake) extension, and then the test would just confirm that those messages show up on the frontend when that fake extension is activated.

    Assigning to @kunal.sachdev for now.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia kunal.sachdev

    kunal.sachdev โ†’ made their first commit to this issueโ€™s fork.

  • Merge request !785#3504664 "Modules that set" โ†’ (Open) created by kunal.sachdev
  • Pipeline finished with Success
    14 days ago
    Total: 940s
    #453058
  • Pipeline finished with Skipped
    13 days ago
    #453227
  • Pipeline finished with Canceled
    13 days ago
    Total: 132s
    #453257
  • Pipeline finished with Failed
    13 days ago
    Total: 518s
    #453263
  • Pipeline finished with Failed
    13 days ago
    Total: 393s
    #453280
  • Pipeline finished with Failed
    13 days ago
    Total: 384s
    #453290
  • Pipeline finished with Failed
    10 days ago
    Total: 525s
    #455868
  • Pipeline finished with Failed
    10 days ago
    Total: 383s
    #455914
  • Pipeline finished with Failed
    10 days ago
    Total: 613s
    #455938
  • Pipeline finished with Success
    10 days ago
    Total: 511s
    #455959
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    This seems really good and straightforward. A few relatively minor suggestions.

  • Pipeline finished with Failed
    8 days ago
    Total: 538s
    #457689
Production build 0.71.5 2024