Change workflow: into a re-usable reference that can be extended

Sounds like a good idea. We'll need to test it well to figure out the syntax but definitely doable.

The syntax is easy, I've already got it working. But yes we need to test it in several of the scenarios.

The code looks good. I triggered the downstream pipelines https://git.drupalcode.org/issue/gitlab_templates-3504083/-/pipelines/41... and it looks good too.

I'd put it RTBC but we're waiting for some testing on other external projects and also testing the usage of the reference.

Here is a test using this MR on Scheduler.
https://git.drupalcode.org/issue/scheduler-3445052/-/pipelines/414840
The pipeline did not run automatically until I added

workflow:
  rules:
    - !reference [ .default-workflow ]
    - if: $CI_COMMIT_BRANCH == "mr326-3504083-workflow-reference"

So in principle the syntax looks good, because if it works for some of the rules it should be the same for all. But some other scenarios would be nice, just to make sure.

Great!

It'd be cool to try and see what happens with the following syntax:

workflow:
  rules:
    - !reference [ .default-workflow ]

And then try:
- A merge request ===> should trigger
- A commit in the default branch ===> should not trigger on fork (it would in the canonical project)
- A pipeline triggered via the web UI ===> should trigger

I've c reated GTD 📌 [ignore] Testing Gitlab Templates MRs Active . First commit on the branch based on d7-basic just added the repo and ref. No pipeline of course. Do we want to test anything on that branch before I add the three workflow lines from #7 ?

I'd say go ahead and add those lines and test.

Before adding adding

workflow:
  rules:
    - !reference [ .default-workflow ]

to this branch, I have done some testing to check the new workflow syntax when it is used only in MR236.

1. This pipeline via UI, which shows that if: $CI_PIPELINE_SOURCE == "web" is working
2. Created MR2 and a pipeline ran immediatley as required, showing that if: $CI_MERGE_REQUEST_IID and if: $CI_PIPELINE_SOURCE == 'merge_request_event' work.
3. I made a commit to the default 'main' branch in that issue fork and no pipeline was triggered

Next, to add that code and repeat these tests.

I have now added the plain workflow syntax to MR2

1. A pipeline ran on that push
2. Edit and commit via web to set max_php:0 and the pipeline was triggered
3. Added the workflow into the 'main' branch. No pipeline was triggered. Usefully the pipeline validation did run, as shown by the first red error, because the reference does not exist in 'default-ref'. Second commit to use MR326 - the validation passes, but no pipeline triggered (as expected)

I also made a temporary change to MR326 so that the downstream d7-basic runs the same issue branch I've been testing above. Here is that downstream pipeline. All OK.

This testing, plus the customised extra rule in #6, gives me confidence that this is working as expected. Ready for feedback.

Everything looks good and works as expected, thanks for the additional testing.

Let's clean up and prepare everything for commit. Setting to "Needs work" for the clean up. We also need to write a bit of docs on this but that can be done here or in the documentation issue.

I've removed the temp branch code and the @todo and made the other requested changes, so this is ready for review.

Thanks for the clean up. It looks good. RTBC.

Merged.

Thank you for making the 1.7.2 release. A nice set of issues and improvements, plus the core version bump of course.

This will allow me to finish 📌 [ignore] Testing Gitlab Templates MRs Active

Automatically closed - issue fixed for 2 weeks with no activity.