Improve coding standards

Created on 3 February 2025, 21 days ago

Problem/Motivation

The validation is throwing warnings for:

  • cspell
  • eslint
  • phpcs
  • phpstan
  • stylelint

Proposed resolution

Let's clean it up

📌 Task
Status

Active

Version

1.5

Component

Code

Created by

🇬🇧United Kingdom joehuggans Harrogate, UK

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joehuggans
  • Pipeline finished with Success
    21 days ago
    Total: 226s
    #413350
  • Pipeline finished with Success
    21 days ago
    Total: 175s
    #413364
  • Pipeline finished with Success
    21 days ago
    Total: 146s
    #413370
  • Pipeline finished with Success
    21 days ago
    Total: 145s
    #413375
  • Pipeline finished with Success
    21 days ago
    Total: 152s
    #413391
  • Pipeline finished with Success
    21 days ago
    Total: 144s
    #413416
  • Pipeline finished with Canceled
    21 days ago
    Total: 131s
    #413427
  • Pipeline finished with Success
    21 days ago
    Total: 209s
    #413431
  • 🇬🇧United Kingdom joehuggans Harrogate, UK

    I've fixed the phpcs and stylelint warnings.

    cspell:
    There are a lot of spelling issues related to URLs for external libraries, I'm not sure how to tell the job to ignore these, I would have expected these to be ignore already by core .cspell.json. I've added some ignored words to the .gitlab-ci.yml. There are some French words, I'm not sure where these are coming from as I can't find them when I search the module.

    The eslint would probably need it's own issue as there is a lot going on, or just leave it for now.

    I'll fix the dependency injection issues for phpstan and then wait for feedback.

  • Pipeline finished with Success
    21 days ago
    Total: 145s
    #413545
  • Pipeline finished with Success
    21 days ago
    Total: 151s
    #413553
  • Pipeline finished with Success
    21 days ago
    Total: 190s
    #413581
  • Pipeline finished with Success
    21 days ago
    Total: 161s
    #413592
  • Pipeline finished with Success
    21 days ago
    Total: 159s
    #413613
  • Pipeline finished with Success
    21 days ago
    Total: 154s
    #413634
  • Pipeline finished with Success
    21 days ago
    Total: 181s
    #413641
  • Pipeline finished with Success
    19 days ago
    Total: 161s
    #415389
Production build 0.71.5 2024