Dependency injection and strict typing in storage classes

Open on Drupal.org →

Created on 1 February 2025, 27 days ago

The last remaining phpstan error is that RestIncidentStorage needs to use dependency injection instead of accessing a service directly with \Drupal::service().

While we're at it, let's autowire the storage services and add strict typing and parameter/return type hints where needed.

📌 Task

Status

Active

Version

4.1

Component

Code

Created by

🇺🇸United States tr Cascadia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!30Dependency injection and strict typing in storage classes
Merged
🇺🇸United States tr
updated 27 days ago

Comments & Activities

Issue created by @tr
Merge request !30Issue #3503798 by tr: Dependency injection and strict typing in storage classes → (Merged) created by tr
Comment 27 days ago →
🇺🇸United States tr Cascadia
Comment 27 days ago →
🇺🇸United States tr Cascadia
There were no new testing errors related to this change.
Pipeline finished with Skipped
27 days ago
#412185
Comment 27 days ago →
🇺🇸United States tr Cascadia

Comment 27 days ago →

tr → committed 822ee0e3 on 4.1.x

Issue #3503798 by tr: Dependency injection and strict typing in storage...

Comment 13 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024