Remove entity loading from \Drupal\entity_usage\Plugin\EntityUsage\Track\BlockField and use entity queries instead

Note that I've tested the code and there looks to be test coverage too but the massive site I'm working on does not use this plugin so I've not done a full performance test.

I've removed the exception throwing because that just should not happen here - if it did it would prevent you saving an entity for something the user cannot control or fix.

Note that I've tested the code and there looks to be test coverage too but the massive site I'm working on does not use this plugin so I've not done a full performance test.

Yes, we do have test coverage, and the changes won't make performance worse IMO, so let's go with it.

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.