- Issue created by @jonathan1055
- Merge request !324#3503426 Add Gitlab Templates Downstream test project → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
I've added the first two branches of Gitlab Templates Downstream to this MR. As I am a maintainer of that project I was allowed to trigger the pipeines, and they ran OK
https://git.drupalcode.org/issue/gitlab_templates-3503426/-/pipelines/41... - 🇪🇸Spain fjgarlin
The changes look great and this could already even be RTBC for those two branches, but as we are creating more branches, I know that this will need extra commits.
- 🇪🇸Spain fjgarlin
Maybe we can use this issue to unify somehow the names of the downstream pipelines for the way they are presented in the UI
I believe that the order of the jobs presented there is alphabetical
- 🇪🇸Spain fjgarlin
My suggestion:
Downstream: Project DrupalVersion [suffix]
Example:
- Downstream: API D7 - Downstream: API D10+ - Downstream: GTD D7 Basic - Downstream: GTD D7 Composer ...
Or maybe we want to shorten
Downstream
withD
, orTest
, or even an emoji→
. The idea of the same prefix is that they are all next to one another. - 🇬🇧United Kingdom jonathan1055
Good idea. I used the → icon as it keeps the names short. This is what we have now:
I think these four branches are all we need in the first instance, so MR324 is ready for review. - 🇬🇧United Kingdom jonathan1055
I have triggered the four GTD jobs on the previous commit, so do you want to check you can do the same on this latest pipeline? No reason to expect it won't work, but good to check.
- 🇪🇸Spain fjgarlin
I just triggered them myself here https://git.drupalcode.org/issue/gitlab_templates-3503426/-/pipelines/41....
The code looks good. RTBC.
-
fjgarlin →
committed eb16ad13 on main authored by
jonathan1055 →
Issue #3503426 by jonathan1055, fjgarlin: Add Gitlab Templates...
-
fjgarlin →
committed eb16ad13 on main authored by
jonathan1055 →
- 🇬🇧United Kingdom jonathan1055
This is the start of new improved test coverage :-)
Automatically closed - issue fixed for 2 weeks with no activity.