BEF Collapsible Filter Not Automatically Opening For First Option

Created on 30 January 2025, 23 days ago

Problem/Motivation

The facets exposed filter should be expanded if you have any elements selected while using your search filter with BEF and having the option "Make filter options collapsible". However, the first element does not trigger this and the filter will always be collapsed. This is because BEF checks for a default value and if none is found, it sets it to be the first element in the options array.

Steps to reproduce

Setup search API server and index
Add a field to your search index for Content Type
Create a search view using the Facets Exposed Filters with the Content Type field created before

Ensure AJAX is turned off
Change your Exposed form style to Better Exposed Filters
Change the Exposed Filter "CONTENT_TYPE" to be "Checkboxes/Radio Buttons".
Under the Advanced Filter Option for the Exposed Filter, select "Make filter options collapsible"
Save your view

Create a couple of content types and nodes for each of them
Ensure all nodes have been indexed
Go to your search view and make as search
Select the first element in your exposed form for content types

Proposed resolution

It's actually a quite simple solution. The FacetsFilter.php file needs to return a empty array as the #default_value when building the exposed element.

Additionally, this fixes a warning from BEF of undefined array key "#default_value".
Warning: Undefined array key "#default_value" in Drupal\better_exposed_filters\Plugin\BetterExposedFiltersWidgetBase->addElementToGroup() (line 155 of /var/www/html/web/modules/contrib/better_exposed_filters/src/Plugin/BetterExposedFiltersWidgetBase.php)

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report

Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States mitchel432

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mitchel432
Comment 23 days ago →
🇺🇸United States mitchel432
Comment 16 days ago →
🇺🇸United States danflanagan8 St. Louis, US
I ran into this a couple days after you and thought it was something with bef. I put in this issue: 🐛 Collapsible checkboxes filter doesn't stay open if only first option is checked Active

Then today I tried to write tests for that issue and couldn't reproduce it! I figured out that Core exposed filters set a #default_value to an empty array while the new facets exposed filter plugin leaves the #default_value as NULL.

Then I found this issue. And here I am.

The patch always sets [] as the default value. Do we need something else if multiple selections are not allowed? An empty string maybe?

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024