- Issue created by @alexpott
- π¬π§United Kingdom alexpott πͺπΊπ
I think we need an update function to delete any existing queue items and if there are queue items tell people to run the batch.
- First commit to issue fork.
- πͺπΈSpain marcoscano Barcelona, Spain
Pushed a quick update function to clean up remaining items from the queue, if existing. Was that what you had in mind?
Thanks!
- π¬π§United Kingdom alexpott πͺπΊπ
Yep exactly something like that... pushed a change to fix the test and to test the update.
-
marcoscano β
committed 78781b06 on 8.x-2.x authored by
alexpott β
Issue #3503296 by alexpott, marcoscano: Remove the queue option from the...
-
marcoscano β
committed 78781b06 on 8.x-2.x authored by
alexpott β
- πͺπΈSpain marcoscano Barcelona, Spain
Great, let's go with this. Thank you! π
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 month ago 9:23am 8 April 2025 - π³π±Netherlands seanB Netherlands
@alexpott @marcoscano A lot of great work to improve entity usage. Nice!
This particular change seems to cause some issues for my current project though. If the batch somehow gets stuck or crashes, you have to start all over again. Yesterday it happened 3 times, after about 1,5 hours of running (we have a lot of plugins).Do you have some more background on the choice to remove the queue options? Is it for performance/maintenance only? Or is there a chance of the outcome just being wrong or inconsistent?
Before we start creating our own drush command or write a patch it would be good to have some more background info.
- πͺπΈSpain marcoscano Barcelona, Spain
Hi @seanb! I am sorry this is causing issues for you.
Maybe @alexpott can chime in with more context if needed, but my recollection is that:
- The queue batch manager was a part of the codebase that had been added in the past as a stopgap solution to the poor performance when regenerating all info. It had been added without test coverage (sorry my bad), and had significant duplication with the normal batch manager
- In the past few months Alex worked on a lot of great improvements to the performance of the module in general, and in particular to the batch regeneration processWith the recent performance improvements (and knowing they are incompatible with how the queue works), it felt unnecessary to keep maintaining both batch managers, especially since they aren't particularly small/trivial. We felt the performance gains of the bulk insert batch manager were enough to justify having the Drush command always work as a standard batch operation, without the need to offer a queue mode as well.