The podcast:payments elements have no #empty_option

Created on 30 January 2025, 1 day ago

Problem/Motivation

Want to create/edit a view with no podcast:payments elements. But when I edit the RSS Feed settings, I see that these elements (Value Type, Value Method, etc) have no '- None -' option.

Steps to reproduce

Install 8.x-1.10. Edit a view created in an earlier version of the module and the RSS Settings won't allow you to set Value Type to '- None -'.

Proposed resolution

Rss::buildOptionsForm() at line 365 iterates over the $form elements. One of the actions here is to add an '#empty_option' to 'select' and 'select_or_other_select' elements.

The 'podcast:payments' element gets skipped because its '#type' is 'details'. We need to add '#empty_option' to the elements of the 'podcast:payments' element.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.10

Component

Code

Created by

🇦🇺Australia kenwest

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024