- Issue created by @alexpott
- π¬π§United Kingdom alexpott πͺπΊπ
Looking good tests are passing and we have less custom words FTW.
The only slightly controversial change is
protected function summariseRevisionGroup()
toprotected function summarizeRevisionGroup()
. I think this is okay because the project is still in beta and also this is a protected method. - First commit to issue fork.
-
marcoscano β
committed 3a37ee12 on 8.x-2.x authored by
alexpott β
Issue #3502706 by alexpott, marcoscano: Tidy up spelling and fail if we...
-
marcoscano β
committed 3a37ee12 on 8.x-2.x authored by
alexpott β
- πͺπΈSpain marcoscano Barcelona, Spain
Looks great, thanks! π I actually intended to fail CI on these too but missed turning it on in the other issue :)
The only slightly controversial change is protected function summariseRevisionGroup() to protected function summarizeRevisionGroup(). I think this is okay because the project is still in beta and also this is a protected method.
I don't feel this is a problem at all. Thanks for bringing it up!
Automatically closed - issue fixed for 2 weeks with no activity.