Tags contained in manual rebase of issue fork triggers pipelines

Thanks for creating the issue.

MR is ready for review: https://git.drupalcode.org/project/gitlab_templates/-/merge_requests/320...

fjgarlin → changed the visibility of the branch main to hidden.

fjgarlin → closed merge request !320

MR330 has the changes. It is still pending review.

I have tried to test this in GTD but not yet sucessfully:

1. The d7-basic branch has two tags (although only 0.0.2 shows in the commit list)
2. I created a new branch named 3503851-tags in the old issue 📌 Add custom variables to set before_script commands in upstream project Active
3. I created MR4 and a pipeline ran immediately (as expected)
4. It needed a change to a file before the "2 commits behind target branch" message was shown. The second pipeline was triggered (as expected)
5. To demonstrate the problem (before testing against MR330) I rebased MR4 hoping to see at least one extra pipeline due to the new tag. But there was only one new pipeline, due to the rebase, no extras

Is this because the branch is not the default branch? The change in MR330 does not look like that is the problem. Until we can replicate the old behavior I cannot say that this change solves the problem.

https://git.drupalcode.org/issue/gitlab_templates_downstream-3503851/-/tags

Rebasing d7-basic on the fork should trigger the behavior we are after, but for whatever reason there is a conflict and cannot be done via the UI.

From slack thread

you could even push a tag in one of the branches in the fork. if I’m right, CI will run, and with the MR, it should not (within the fork)

That's a good idea, and it worked. I pushed tag 0.0.3 to the 3503851-tags branch and a pipeline was triggered.
I then committed a change to use this MR, pushed tag 0.0.4 - and no pipeline was triggered.

Here are the commits and here are the tags with pipeline on 0.0.3 but not on 0.0.4

This is not precisely the scenario that @jurgenhass reported, but I think this does demonstrate the same behavior, and therefore shows that MR330 fixes the problem, so this is RTBC

Thanks for the extra set of eyes and testing. Merged.

Automatically closed - issue fixed for 2 weeks with no activity.