Resolve PHPStan issues

Created on 24 January 2025, 3 months ago

Problem/Motivation

The PHPStan tests throw warnings and fail when the code is built via GitLab pipelines.

Steps to reproduce

Build the current branch. The output will look like what is found at https://git.drupalcode.org/issue/ableplayer-3454701/-/jobs/3976581.

Proposed resolution

Update non-test code to use dependency injection and evaluate test files to see if they are still valid. If not, perhaps delete the test files and recreate them as tests are rebuilt.

📌 Task

Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States theMusician

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @theMusician
Pipeline finished with Failed
about 2 months ago
Total: 443s
#437152
Pipeline finished with Failed
about 2 months ago
Total: 184s
#437168
Pipeline finished with Failed
about 2 months ago
Total: 166s
#437171
Comment about 2 months ago →
🇺🇸United States theMusician
Work internally continues on this.

The non-test files now pass PHP Stan.
https://git.drupalcode.org/issue/ableplayer-3502026/-/jobs/4520088

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024