- Issue created by @apmsooner
- πΊπΈUnited States apmsooner
@klausi,
I added the fallback because the values could technically be null if the image is invalid. Thinking with migrations and such, there could be bad images and the graphql_compose module expects a nonNull value in its schema. I mean theres nothing preventing anyone from setting the value for width/height to null so I felt it was better to have a safe fallback.
https://git.drupalcode.org/project/graphql_compose/-/blob/2.4.x/modules/...
- πΊπΈUnited States apmsooner
You could essentially have a valid name & url but null width/height which would cause issues with the schema expected. I stand by the PR as is.
- π¦πΉAustria klausi π¦πΉ Vienna
Thanks, I cleaned up the rest of the code and improved the test code.
This will be merged soon.
-
klausi β
committed ebb04a76 on 8.x-4.x authored by
apmsooner β
fix(image_derivative): Ignore SVG files and cleanup height/width...
-
klausi β
committed ebb04a76 on 8.x-4.x authored by
apmsooner β
- Status changed to Fixed
10 days ago 1:29pm 27 March 2025 Automatically closed - issue fixed for 2 weeks with no activity.