- Issue created by @fjgarlin
- πΊπΈUnited States phenaproxima Massachusetts
I am reproducing this on 2.0.x.
The problem is that the sources have to opt in to showing a local task by putting it in their annotation. For example, the drupalorg_jsonapi source does it: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...
But the drupal_core source doesn't: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...
So we have a couple of options here.
- We could add that to the drupal_core source, except that it would create a conflict with the existing /admin/modules (Extend) tab, since they both show core modules.
- We could do nothing, and close this as "works as designed".
- πͺπΈSpain fjgarlin
/admin/modules
shows both core and contrib modules in the system, so whilst PB is not a full replacement for that page (we're not there yet), I think we should add the tab for "Core modules" if we are willing to offer that via PB.Maybe the name of the tab for "Contrib modules" should be "Contrib modules" instead of "Browse", and the "Core modules" should be "Core modules". Or maybe not, I'm not sure, this is UX, but yeah, my point remains that the plugin is available and when enabled, you can't see it anywhere (this is why I created it as a bug).
- πΊπΈUnited States phenaproxima Massachusetts
I agree that if we're going to be enabling a local task for core modules, the contrib source should not be named "Browse". It was only kept that way for parity with 2.0.x to minimize disruption while I was making the seismic change of ripping out the Svelte-managed tabbing. But now that the tabs are regular local tasks, "Browse" is nonsensical.
- π¬πͺGeorgia davit.magaldadze
davit.magaldadze β made their first commit to this issueβs fork.
- First commit to issue fork.
- Merge request !684Issue #3501455 by gprtskh: Expose the "Core modules" source plugin as a local task β (Merged) created by Unnamed author
- First commit to issue fork.
- πΊπΈUnited States phenaproxima Massachusetts
Looks fine to me! The failing tests are probably random failures, but I don't have permission to rerun those jobs.
- πΊπΈUnited States chrisfromredfin Portland, Maine
re-ran tests and they passed. will merge this soon, after the larger categories one.
-
chrisfromredfin β
committed 5812789b on 2.0.x authored by
gprtskh β
Issue #3501455: Expose the "Core modules" source plugin as a local task
-
chrisfromredfin β
committed 5812789b on 2.0.x authored by
gprtskh β
- πΊπΈUnited States chrisfromredfin Portland, Maine
Thanks for the help! Great to see some new names in the queue :)
Automatically closed - issue fixed for 2 weeks with no activity.