Unable to access the "Core modules" source

Created on 22 January 2025, 6 months ago

Problem/Motivation

Enable "Contrib modules" and "Core modules" plugins.

Visit the "Extend > Browse" page. You can see the "Contrib modules", but there is no way to access to the "Core modules".

Tried:
- /admin/modules
- /admin/index

The URL /admin/modules/browse/drupal_core shows the page that we want, but that URL is not exposed or linked anywhere on the project.

Proposed resolution

Create tab or link somewhere.

๐Ÿ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

๐Ÿ‡ช๐Ÿ‡ธSpain fjgarlin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @fjgarlin
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    I am reproducing this on 2.0.x.

    The problem is that the sources have to opt in to showing a local task by putting it in their annotation. For example, the drupalorg_jsonapi source does it: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...

    But the drupal_core source doesn't: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...

    So we have a couple of options here.

    • We could add that to the drupal_core source, except that it would create a conflict with the existing /admin/modules (Extend) tab, since they both show core modules.
    • We could do nothing, and close this as "works as designed".
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts
  • ๐Ÿ‡ช๐Ÿ‡ธSpain fjgarlin

    /admin/modules shows both core and contrib modules in the system, so whilst PB is not a full replacement for that page (we're not there yet), I think we should add the tab for "Core modules" if we are willing to offer that via PB.

    Maybe the name of the tab for "Contrib modules" should be "Contrib modules" instead of "Browse", and the "Core modules" should be "Core modules". Or maybe not, I'm not sure, this is UX, but yeah, my point remains that the plugin is available and when enabled, you can't see it anywhere (this is why I created it as a bug).

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    I agree that if we're going to be enabling a local task for core modules, the contrib source should not be named "Browse". It was only kept that way for parity with 2.0.x to minimize disruption while I was making the seismic change of ripping out the Svelte-managed tabbing. But now that the tabs are regular local tasks, "Browse" is nonsensical.

  • ๐Ÿ‡ฌ๐Ÿ‡ชGeorgia davit.magaldadze

    davit.magaldadze โ†’ made their first commit to this issueโ€™s fork.

  • First commit to issue fork.
  • Pipeline finished with Failed
    5 months ago
    Total: 386s
    #406353
  • Pipeline finished with Canceled
    5 months ago
    Total: 91s
    #406398
  • Pipeline finished with Failed
    5 months ago
    Total: 1675s
    #406399
  • Pipeline finished with Success
    5 months ago
    Total: 529s
    #406414
  • ๐Ÿ‡ฌ๐Ÿ‡ชGeorgia gprtskh
  • First commit to issue fork.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Looks fine to me! The failing tests are probably random failures, but I don't have permission to rerun those jobs.

  • Pipeline finished with Success
    5 months ago
    Total: 1447s
    #407660
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    re-ran tests and they passed. will merge this soon, after the larger categories one.

  • Pipeline finished with Success
    5 months ago
    Total: 813s
    #408292
  • Pipeline finished with Skipped
    5 months ago
    #408319
  • Pipeline finished with Skipped
    5 months ago
    #408326
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    Thanks for the help! Great to see some new names in the queue :)

  • Pipeline finished with Success
    5 months ago
    Total: 486s
    #408321
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    5 months ago
    Total: 1647s
    #429959
  • Pipeline finished with Failed
    21 days ago
    Total: 257s
    #525407
  • Pipeline finished with Failed
    19 days ago
    Total: 280s
    #527248
  • Pipeline finished with Failed
    19 days ago
    Total: 420s
    #527290
  • Pipeline finished with Failed
    19 days ago
    Total: 201s
    #527356
  • Pipeline finished with Failed
    18 days ago
    #527809
  • Pipeline finished with Failed
    18 days ago
    Total: 374s
    #527814
  • Pipeline finished with Success
    16 days ago
    Total: 359s
    #529072
  • Pipeline finished with Success
    16 days ago
    Total: 216s
    #529085
Production build 0.71.5 2024